fix: code review round 2 - logging, cleanup, TOC, simplify converter

This commit is contained in:
truetype committed 2026-07-22 15:58:01 +02:00
1 parent 723e50eb25
commit 45f08c8b9b
4 files changed
+45 -36

No files matched your search

+6 -4
View File
@@ -1,15 +1,14 @@
import os
import uuid
import logging
import threading
from flask import Blueprint, request, jsonify, Response, send_file, render_template, current_app
from werkzeug.utils import secure_filename
from config import SUPPORTED_FORMATS, OUTPUT_FORMATS_BY_INPUT
from bookish.services.sse_manager import (
create_task, generate_sse_events, update_progress,
mark_error, get_status, cleanup_task
)
from bookish.services.sse_manager import create_task, generate_sse_events, get_status
from bookish.services.converter import run_conversion, get_format_from_ext
logger = logging.getLogger(__name__)
convert_bp = Blueprint("convert", __name__)
ALLOWED_EXTENSIONS = set(SUPPORTED_FORMATS.keys())
@@ -82,6 +81,8 @@ def upload():
)
thread.start()
logger.info("Conversione avviata: %s -> %s (task=%s)", input_ext, output_format, task_id)
return jsonify({
"task_id": task_id,
"input_format": input_ext,
@@ -115,6 +116,7 @@ def download(filename):
return jsonify({"error": "File non trovato o già rimosso"}), 404
ext = os.path.splitext(safe)[1].lower().lstrip(".")
logger.info("Download: %s.%s", safe, ext)
mime = SUPPORTED_FORMATS.get(ext, {}).get("mime", "application/octet-stream")
download_name = f"converted.{ext}"